fix: 320 azure workload identity authentication#321
Open
MCBoarder289 wants to merge 2 commits into
Open
Conversation
When reading delta tables from ADLS via workload_identity (commonly in k8s), DuckDB's credential chain isn't passed through to delta-kernel's credential resolution path, causing incorrect resolution. This change passes workload_identity variables to delta-kernel's expected options so that resolve_credential_auto() correctly leverages the workload_identity path. Fixes duckdb#320
Adds test/sql/cloud/azure/workload_identity_auth.test following the same pattern as cli_auth.test and spn_auth.test. The test is guarded by require-env on AZURE_CLIENT_ID, AZURE_TENANT_ID, AZURE_FEDERATED_TOKEN_FILE, and AZURE_STORAGE_ACCOUNT — it will skip silently in all existing CI pipelines (Azurite, cloud SPN-based) since none provide a federated token environment. Included to document expected behavior and provide coverage if an AKS-based CI runner with workload identity is added in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed PR to fix #320. I have tested this locally with an AKS cluster with a federated workload identity.
Please let me know if you have any feedback!
I also figure the test I tried to add won't run because I'm not familiar with your CI/CD setup. Hopefully it's useful, but definitely open to any adjustments there.