Fix/onelake dfs trailing slash v1.5#180
Merged
benfleis merged 7 commits intoJul 14, 2026
Merged
Conversation
plus other aesthetic cleanups
A trailing '/' is a directory hint, not part of the resource name, but it was passed straight into GetFileClient(parsed_url.path). OneLake's DFS endpoint rejects a GetProperties on a trailing-slash path with 403 AuthenticationFailed (the slash-less path returns 200), so any DirectoryExists/FileExists/glob on a directory fails. This breaks e.g. duckdb-delta partitioned writes, which probe the table directory. Strip a single trailing slash from the path used to build the file client. info.path is left untouched, so the directory-marker check in LoadRemoteFileInfo still works. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
Mac OS Build fail was ephemeral, same build passed locally and in my account's CI. |
Contributor
|
thanks, it works, at least now i have the real limitation delta does not support partition :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re PR #177 , noted here