Strip trailing slash before DFS GetProperties (fixes OneLake 403)#174
Merged
Conversation
A trailing '/' is a directory hint, not part of the resource name, but it was passed straight into GetFileClient(parsed_url.path). OneLake's DFS endpoint rejects a GetProperties on a trailing-slash path with 403 AuthenticationFailed (the slash-less path returns 200), so any DirectoryExists/FileExists/glob on a directory fails. This breaks e.g. duckdb-delta partitioned writes, which probe the table directory. Strip a single trailing slash from the path used to build the file client. info.path is left untouched, so the directory-marker check in LoadRemoteFileInfo still works. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
djouallah
marked this pull request as ready for review
May 29, 2026 14:28
djouallah
added a commit
to djouallah/duckrun
that referenced
this pull request
Jun 6, 2026
duckdb-azure's glob() can't list OneLake (abfss://) directories (duckdb/duckdb-azure#174, unreleased): glob('<schema>/*') returns zero rows, so glob-based relation discovery came back empty and standalone read-only commands (dbt test/show/docs) failed with "schema does not exist" for every model. dbt build masked it because the materialization creates the delta_scan views itself. For abfss:// stores, enumerate the schema's table directories with the OneLake / ADLS Gen2 DFS "List Paths" REST API (new remote.py), using the same bearer token that authenticates the Delta reads/writes. Local and az:// stores keep using DuckDB glob, which works there. Verified locally: standalone `dbt test` against real OneLake now PASS=25 ERROR=0 (was: every test ERROR). Also revert the forced curl azure transport in secret.py: it's not the fix and it breaks non-Linux hosts (CURLE 43); delta_scan works on the default transport. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
djouallah
added a commit
to djouallah/duckrun
that referenced
this pull request
Jun 8, 2026
duckdb-azure's glob() can't list OneLake (abfss://) directories (duckdb/duckdb-azure#174, unreleased): glob('<schema>/*') returns zero rows, so glob-based relation discovery came back empty and standalone read-only commands (dbt test/show/docs) failed with "schema does not exist" for every model. dbt build masked it because the materialization creates the delta_scan views itself. For abfss:// stores, enumerate the schema's table directories with the OneLake / ADLS Gen2 DFS "List Paths" REST API (new remote.py), using the same bearer token that authenticates the Delta reads/writes. Local and az:// stores keep using DuckDB glob, which works there. Verified locally: standalone `dbt test` against real OneLake now PASS=25 ERROR=0 (was: every test ERROR). Also revert the forced curl azure transport in secret.py: it's not the fix and it breaks non-Linux hosts (CURLE 43); delta_scan works on the default transport. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
@benfleis any chance you have a look |
Member
|
Thanks @djouallah! This needs to land against v1.5-variegata. I'll backport that one and link it here; this one will either get landed later (I need to do a v1.5 sync to main first), either directly from here or as a bigger forward port from v1.5 PR. |
benfleis
added a commit
that referenced
this pull request
Jul 13, 2026
…ckport #174) (#177) * Strip trailing slash before DFS GetProperties (fixes OneLake 403) A trailing '/' is a directory hint, not part of the resource name, but it was passed straight into GetFileClient(parsed_url.path). OneLake's DFS endpoint rejects a GetProperties on a trailing-slash path with 403 AuthenticationFailed (the slash-less path returns 200), so any DirectoryExists/FileExists/glob on a directory fails. This breaks e.g. duckdb-delta partitioned writes, which probe the table directory. Strip a single trailing slash from the path used to build the file client. info.path is left untouched, so the directory-marker check in LoadRemoteFileInfo still works. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Also: * update v1.5 refs * update winbuild for VS 18 * update CI build tags -> v1.5.4, also actionlint + CI yaml cleanups --------- Co-authored-by: djouallah <djouallah@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
@djouallah BTW, is this issue filed upstream with OneLake? Is it defensive practice in DFS against the '/' trailing slash sentinals used in S3, and presumeably AZ Blob store? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the DFS filesystem,
CreateHandlepassesparsed_url.pathstraight intoGetFileClient(...), so a trailing/ends up on the wire in the subsequentGetProperties()call. A trailing slash is only a directory hint, not part of the resource name.OneLake's DFS endpoint (
*.dfs.fabric.microsoft.com) rejects aGetPropertieson a trailing-slash path with403 AuthenticationFailed/Forbidden, while the identical request without the slash returns200. BecauseDirectoryExists,FileExists, andGlob(no-wildcard) all funnel throughOpenFile→CreateHandle→LoadRemoteFileInfo→GetProperties, any directory probe on OneLake fails.This surfaces in practice as duckdb-delta partitioned writes failing:
PhysicalCopyToFileprobes the target table directory viaDirectoryExists("…/Tables/dbo/<table>/"), producing:Reproduces standalone, no write needed:
Fix
Strip a single trailing
/from the path used to build the file client.info.pathis left untouched, so the directory-marker detection inLoadRemoteFileInfo(StringUtil::EndsWith(afh.GetPath(), "/")) still works; only what is sent to the service changes. Real file keys never end in/, so reads/writes/Createare unaffected.