force blob (write) sync every 10k appends#169
Merged
benfleis merged 1 commit intoMay 12, 2026
Conversation
This addresses duckdb/duckdb-delta#299, which reports users hitting Azure's 100k outstanding staged block limit and failing. This PR: - main: triggers Commit of staged blocks when `max` is reached - generalizes AzureReadOptions -> AzureOptions in order to - add AzureOptions.write_staged_blocks_max (default=10k) - also, simplifies block mgmt to counts (instead of vectors) It introduces a new option: > `azure_write_staged_blocks_max` -- Maximum number of staged > (uncommitted) blocks before an automatic mid-write commit. > Azure limits blobs to 100,000 total blocks; this safety valve > prevents hitting that limit by committing staged blocks early. > Default: 10000.
Member
Author
|
There are more lines than preferred due to the rename of AzureReadOptions -> AzureOptions Key changes: |
samansmink
reviewed
May 12, 2026
| idx_t buffer_size = 1 * 1024 * 1024; | ||
| struct AzureOptions { | ||
| int32_t read_transfer_concurrency = 5; | ||
| int64_t read_transfer_chunk_size = (int64_t)8 * 1024 * 1024; |
Member
There was a problem hiding this comment.
Was the chunk size change deliberate? If so it probably should go into the PR description
Member
Author
There was a problem hiding this comment.
Ah yes, I sliced apart the original PR into pre- and post- v1.5.3 parts but missed that one. I'll add comment since it's a good adjustment in any case.
Contributor
Member
Author
|
Hi @djouallah this alone doesn't fully address the problem, it exposes a different limit in Azure. I'm awaiting the review/landing of #168. After that lands it will be in nightly builds to confirm. |
Merged
benfleis
added a commit
that referenced
this pull request
Jul 13, 2026
**Forward fill v1.5 variegata PRs -> main** Forward-ports: - #169 — force blob (write) sync every 10k appends (Azure 100k staged block limit) - #168 — buffer/stage/commit rewrite: fixed-size local write buffer (mirrors S3), configurable buffer size, fixes DFS sync-offset - #173 — actionlint CI fixes (ccache key, setup-python@v5) Not forward-ported (branch-specific to v1.5-variegata, don't apply to main): #166 (duckdb pin bump to variegata tag), #167 (CI refs pinned to v1.5-variegata / v1.5.3). #162 already on main via separate cherry-picks. **CI/Build** - Needed action version updates + Actionlint fixes - Windows build/image vcvars fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses duckdb/duckdb-delta#299, which reports users hitting Azure's 100k outstanding staged block limit and failing.
maxis reachedIt introduces a new option: