Azure metadata cache hookup and Azure integration test updates#161
Open
zsy056 wants to merge 7 commits into
Open
Azure metadata cache hookup and Azure integration test updates#161zsy056 wants to merge 7 commits into
zsy056 wants to merge 7 commits into
Conversation
|
Really waiting for this one :) |
Co-authored-by: Shaoyu Zhang <zsy056@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Shaoyu Zhang <zsy056@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Shaoyu Zhang <zsy056@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Shaoyu Zhang <zsy056@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Shaoyu Zhang <zsy056@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Shaoyu Zhang <zsy056@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Hi @benfleis , wondering if by any chance you can help review this change? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure metadata cache hookup and Azure integration test updates
Summary
This PR wires
duckdb-azureinto DuckDB HTTPFS-style metadata caching and restores Azure multi-file auto-glob behavior for bare Blob directory paths on HNS-backed accounts.What changed
GetProperties()/ file info lookup) into HTTPFS-aligned metadata cache behavior.enable_http_metadata_cache = falsenow uses a query-local cache.enable_http_metadata_cache = truenow uses a shared/global cache.shared_mutexfor the shared/globalAzureMetadataCacheto allow concurrent readers with exclusive writes.Globpath return only regular files so HNS directories do not suppress DuckDB's fallback auto-glob for multi-file readers.type=filefor non-empty items before seeding metadata, so flat HNS Blob listings do not misclassify directory entries as files.test/sql/azure.testtest/sql/azure_glob.testto the original auto-glob form (read_csv('az://.../partitioned'))Why
Before this change, repeated Azure file opens inside a single query were still issuing repeated metadata lookups. On the benchmark parquet workload, that kept Azure
HEADtraffic high and wall time far above direct download speed.The metadata-cache hookup removes those repeated metadata calls while preserving HTTPFS-style semantics:
Benchmark results
Benchmark workload:
76.3 MiBuncompressed parquet20row groupsPrimary before/after comparison (same
curl+ object-cache-on +4 MB / 4 MBsetup):47.257 s14.443 s1.61 MiB/s5.28 MiB/s#HEAD221#GET2121Net result:
Post-fix comparison for the two configurations we want to highlight:
#HEAD#GETchunk = 4 MiB,buffer = 4 MiB14.4435.28121chunk = 1 MiB,buffer = 1 MiB14.1945.38181Validation