Move default region list to a GetDefaultAwsRegions() utility#168
Merged
Conversation
Addresses review feedback on duckdb#167: the hardcoded region sweep set no longer lives inline in cloudformation_functions.cpp. A // FIXME records the plan to replace it with live ec2:DescribeRegions/account:ListRegions enumeration.
Addresses review feedback on duckdb#167: disentangle the error slot from the 'region' column and leave room for non-region error conditions later. The sentinel-row semantics are unchanged; only the column/field name differs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #167: the hardcoded region sweep set no longer lives inline in cloudformation_functions.cpp. A
// FIXMErecords the plan to replace it with live ec2:DescribeRegions/account:ListRegions enumeration.Thanks @Tmonster for the comment in the PR.