Use the new canvas renderer - #239
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Canvas component to use the new renderer provided by @design-core/core, wiring it into the core canvas lifecycle.
Changes:
- Import
CanvasRendererfrom@design-core/core. - Configure
core.canvasto useCanvasRendereron mount. - Re-apply the renderer when the
coreprop instance changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
34
| // set the renderer | ||
| this.props.core.canvas.setRenderer(CanvasRenderer); | ||
|
|
||
| // set the paint callback | ||
| this.props.core.canvas.setExternalPaintCallbackFunction(this.paint.bind(this)) | ||
|
|
Comment on lines
50
to
55
| if (prevProps.core !== this.props.core) { | ||
| prevProps.core.canvas.setCursorCallbackFunction(undefined); | ||
| this.props.core.canvas.setRenderer(CanvasRenderer); | ||
| this.props.core.canvas.setExternalPaintCallbackFunction(this.paint.bind(this)); | ||
| this.props.core.canvas.setCursorCallbackFunction(this.boundOnCursorChange); | ||
| this.paint(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.