pre-commit (diff): llvm/llvm-project/compare/main...fhahn:ce-disjoint-or - #1188
Open
zyw-bot wants to merge 4 commits into
Open
pre-commit (diff): llvm/llvm-project/compare/main...fhahn:ce-disjoint-or#1188zyw-bot wants to merge 4 commits into
zyw-bot wants to merge 4 commits into
Conversation
fhahn
added a commit
to fhahn/llvm-project
that referenced
this pull request
Sep 3, 2026
Use m_NSWAddLike instead of m_NSWAdd to also handle 'or disjoint' in signed decomposition. Leads to a number of additional folds end-to-end: dtcxzyw/llvm-opt-benchmark-nightly#1188 Compile-time impact is in the noise in almost all cases except lencod with ThinLTO. On current main, compile-time for the workload regresses by ~3%, but almost all additional time is spent in SLP: after some branches got removed and BBs got merged got bigger, and SLP compile-time scales super-linearly in block size in some cases. Together with llvm#220968 the regression goes down to ~+1.18% on the workload. I have 2 more prototype patches that reduce the overhead by another ~0.30%. I am not sure if the compile-time issue should block the patch. https://llvm-compile-time-tracker.com/compare.php?from=ffe87191eb7090340f12056455104145670ed7e8&to=c073db66b714d3dd26c573ad8371ab8b117890a9&stat=instructions:u Alive2 Proof: https://alive2.llvm.org/ce/z/ZVFEox
fhahn
added a commit
to llvm/llvm-project
that referenced
this pull request
Sep 4, 2026
Use m_NSWAddLike instead of m_NSWAdd to also handle 'or disjoint' in signed decomposition. Leads to a number of additional folds end-to-end: dtcxzyw/llvm-opt-benchmark-nightly#1188 Compile-time impact is in the noise in almost all cases except lencod with ThinLTO. On current main, compile-time for the workload regresses by ~3%, but almost all additional time is spent in SLP: after some branches got removed and BBs got merged got bigger, and SLP compile-time scales super-linearly in block size in some cases. Together with #220968 the regression goes down to ~+1.18% on the workload. I have 2 more prototype patches that reduce the overhead by another ~0.30%. I am not sure if the compile-time issue should block the patch. https://llvm-compile-time-tracker.com/compare.php?from=ffe87191eb7090340f12056455104145670ed7e8&to=c073db66b714d3dd26c573ad8371ab8b117890a9&stat=instructions:u Alive2 Proof: https://alive2.llvm.org/ce/z/ZVFEox PR: #220990
llvm-sync Bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 4, 2026
…#220990) Use m_NSWAddLike instead of m_NSWAdd to also handle 'or disjoint' in signed decomposition. Leads to a number of additional folds end-to-end: dtcxzyw/llvm-opt-benchmark-nightly#1188 Compile-time impact is in the noise in almost all cases except lencod with ThinLTO. On current main, compile-time for the workload regresses by ~3%, but almost all additional time is spent in SLP: after some branches got removed and BBs got merged got bigger, and SLP compile-time scales super-linearly in block size in some cases. Together with llvm/llvm-project#220968 the regression goes down to ~+1.18% on the workload. I have 2 more prototype patches that reduce the overhead by another ~0.30%. I am not sure if the compile-time issue should block the patch. https://llvm-compile-time-tracker.com/compare.php?from=ffe87191eb7090340f12056455104145670ed7e8&to=c073db66b714d3dd26c573ad8371ab8b117890a9&stat=instructions:u Alive2 Proof: https://alive2.llvm.org/ce/z/ZVFEox PR: llvm/llvm-project#220990
llvm-upstreamsync Bot
pushed a commit
to qualcomm/cpullvm-toolchain
that referenced
this pull request
Sep 4, 2026
…#220990) Use m_NSWAddLike instead of m_NSWAdd to also handle 'or disjoint' in signed decomposition. Leads to a number of additional folds end-to-end: dtcxzyw/llvm-opt-benchmark-nightly#1188 Compile-time impact is in the noise in almost all cases except lencod with ThinLTO. On current main, compile-time for the workload regresses by ~3%, but almost all additional time is spent in SLP: after some branches got removed and BBs got merged got bigger, and SLP compile-time scales super-linearly in block size in some cases. Together with llvm/llvm-project#220968 the regression goes down to ~+1.18% on the workload. I have 2 more prototype patches that reduce the overhead by another ~0.30%. I am not sure if the compile-time issue should block the patch. https://llvm-compile-time-tracker.com/compare.php?from=ffe87191eb7090340f12056455104145670ed7e8&to=c073db66b714d3dd26c573ad8371ab8b117890a9&stat=instructions:u Alive2 Proof: https://alive2.llvm.org/ce/z/ZVFEox PR: llvm/llvm-project#220990
Iasonaskrpr
pushed a commit
to Iasonaskrpr/llvm-project
that referenced
this pull request
Sep 4, 2026
Use m_NSWAddLike instead of m_NSWAdd to also handle 'or disjoint' in signed decomposition. Leads to a number of additional folds end-to-end: dtcxzyw/llvm-opt-benchmark-nightly#1188 Compile-time impact is in the noise in almost all cases except lencod with ThinLTO. On current main, compile-time for the workload regresses by ~3%, but almost all additional time is spent in SLP: after some branches got removed and BBs got merged got bigger, and SLP compile-time scales super-linearly in block size in some cases. Together with llvm#220968 the regression goes down to ~+1.18% on the workload. I have 2 more prototype patches that reduce the overhead by another ~0.30%. I am not sure if the compile-time issue should block the patch. https://llvm-compile-time-tracker.com/compare.php?from=ffe87191eb7090340f12056455104145670ed7e8&to=c073db66b714d3dd26c573ad8371ab8b117890a9&stat=instructions:u Alive2 Proof: https://alive2.llvm.org/ce/z/ZVFEox PR: llvm#220990
addmisol
pushed a commit
to addmisol/llvm-project2
that referenced
this pull request
Sep 6, 2026
Use m_NSWAddLike instead of m_NSWAdd to also handle 'or disjoint' in signed decomposition. Leads to a number of additional folds end-to-end: dtcxzyw/llvm-opt-benchmark-nightly#1188 Compile-time impact is in the noise in almost all cases except lencod with ThinLTO. On current main, compile-time for the workload regresses by ~3%, but almost all additional time is spent in SLP: after some branches got removed and BBs got merged got bigger, and SLP compile-time scales super-linearly in block size in some cases. Together with llvm#220968 the regression goes down to ~+1.18% on the workload. I have 2 more prototype patches that reduce the overhead by another ~0.30%. I am not sure if the compile-time issue should block the patch. https://llvm-compile-time-tracker.com/compare.php?from=ffe87191eb7090340f12056455104145670ed7e8&to=c073db66b714d3dd26c573ad8371ab8b117890a9&stat=instructions:u Alive2 Proof: https://alive2.llvm.org/ce/z/ZVFEox PR: llvm#220990
vadimkotov
pushed a commit
to vadimkotov/llvm-project
that referenced
this pull request
Sep 8, 2026
Use m_NSWAddLike instead of m_NSWAdd to also handle 'or disjoint' in signed decomposition. Leads to a number of additional folds end-to-end: dtcxzyw/llvm-opt-benchmark-nightly#1188 Compile-time impact is in the noise in almost all cases except lencod with ThinLTO. On current main, compile-time for the workload regresses by ~3%, but almost all additional time is spent in SLP: after some branches got removed and BBs got merged got bigger, and SLP compile-time scales super-linearly in block size in some cases. Together with llvm#220968 the regression goes down to ~+1.18% on the workload. I have 2 more prototype patches that reduce the overhead by another ~0.30%. I am not sure if the compile-time issue should block the patch. https://llvm-compile-time-tracker.com/compare.php?from=ffe87191eb7090340f12056455104145670ed7e8&to=c073db66b714d3dd26c573ad8371ab8b117890a9&stat=instructions:u Alive2 Proof: https://alive2.llvm.org/ce/z/ZVFEox PR: llvm#220990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read the instructions in the README to reproduce the results locally.
cc @fhahn
Current: llvm/llvm-project@main...fhahn:ce-disjoint-or
Baseline commit: llvm/llvm-project@992d5d0
Changes in statistics
Top changes:
Diff report
Download the full diff list: z_fulldiff.csv
Artifacts
Selected raw llvm-relaxed-diff outputs (23 file pairs, up to 100 MB) can be downloaded from https://github.com/dtcxzyw/llvm-opt-benchmark-nightly/actions/runs/33761941011.
Grouped changes
report: add > sub
report: add < sub
report: add == sub