virusLib: name ControlCommand 109 as DSP_CLOCK_ADJUSTMENT - #282
Open
insolentconstruct wants to merge 1 commit into
Open
virusLib: name ControlCommand 109 as DSP_CLOCK_ADJUSTMENT#282insolentconstruct wants to merge 1 commit into
insolentconstruct wants to merge 1 commit into
Conversation
insolentconstruct
force-pushed
the
virus/dsp-clock-adjustment-enum
branch
from
August 1, 2026 04:53
b30ae68 to
3952fc6
Compare
The boot array in microcontroller.cpp's sendInitControlCommands already carries a comment for this exact page and index (0x734x, 109) describing it as a DSP clock adjustment in percent, default 0x64 = 100%, maximum 0x79 = 121%. Only the enumerator was still unattributed, so the name and the comment disagreed. Checked against the emulated DSP rather than taken from the comment: sending the command via PARAM_CHANGE_D reprograms the PLL. Values 100, 110 and 121 yield PLL MF register values 0x8e, 0x98 and 0xa3 (133.594, 143.002 and 153.35 MHz), an exact mf = value + 42 relationship — tighter than the comment's "roughly". As a control, the same value sent to the neighbouring unnamed index 108 produced the same generic clock-recompute log line but left the clock at its default, so the effect belongs to index 109 specifically and is not a side effect of any write to that page. No behaviour change; the enumerator value is untouched.
insolentconstruct
force-pushed
the
virus/dsp-clock-adjustment-enum
branch
from
August 1, 2026 04:55
3952fc6 to
07ce459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microcontroller.cpp'ssendInitControlCommandsboot array already carries a comment againstthis exact page and index (
0x734x, 109) describing it as a DSP clock adjustment in percent,default
0x64= 100%, maximum0x79= 121%. Only the enumerator was still unattributed, so thename and the neighbouring comment disagreed with each other.
Rather than take the comment's word for it, the command was exercised against the emulated DSP.
Sent via
PARAM_CHANGE_D, it reprograms the PLL: values 100, 110 and 121 produce PLLMFregister values
0x8e,0x98and0xa3(133.594, 143.002 and 153.35 MHz) — an exactmf = value + 42relationship, tighter than the comment's "roughly".As a control, sending the same value to the neighbouring unnamed index 108 produced the same
generic clock-recompute log line but left the clock at its default — so the effect belongs to
index 109 specifically, and is not a side effect of any write to that page.
No behaviour change — the enumerator's value is untouched, only its name.