Skip to content

Fix Patch Manager search-handle leaks causing unbounded CPU growth #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartun83 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Patch Manager search-handle leaks causing unbounded CPU growth #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c086e
Fix Patch Manager search handle leak causing unbounded CPU growth
kartun83 Jul 4, 2026
f4f2581
Fix DB::m_cancelledSearches unbounded growth
kartun83 Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions source/jucePluginEditorLib/patchmanager/patchmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,16 @@ namespace jucePluginEditorLib::patchManager
results.assign(_search.results.begin(), _search.results.end());

if(results.empty())
{
// the search found no match, but it must still be cancelled/removed from the DB's
// search list, otherwise it leaks forever and every subsequent bank load / patch
// update has to scan it in DB::updateSearches, causing CPU usage to grow unbounded
runOnUiThread([this, handle]
{
cancelSearch(handle);
});
return;
}

if(results.size() > 1)
{
Expand Down
9 changes: 8 additions & 1 deletion source/jucePluginLib/patchdb/db.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,14 @@ namespace pluginLib::patchDB
return;

std::unique_lock lock(m_searchesMutex);
m_cancelledSearches.insert(_handle);

// only remember the handle as cancelled if the search may still be picked up by executeSearch
// later (i.e. it's still queued/running). A search that has already completed will never be
// looked at again, so tracking it here would leak the handle in m_cancelledSearches forever.
const auto it = m_searches.find(_handle);
if(it != m_searches.end() && it->second->state != SearchState::Completed)
m_cancelledSearches.insert(_handle);

m_searches.erase(_handle);
}

Expand Down