feat: modernization phase 5 PR5#56
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR (Modernization Phase 5 PR5) adds regression lock-in for a couple of already-correct on-wire behaviors in the source transmit path, plus accompanying documentation updates for Phase 5 completion.
Changes:
- Add transmit-builder regression tests covering (1) NULL+PAP sequence consumption in a single frame and (2) universe-discovery reserved-field zeroing and universe-list sorting.
- Add an internal
sACNSourcetest seam to rebuild and return universe-discovery pages for unit testing. - Document Phase 5 completion/status and PR5’s specific coverage additions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Tests/sACNKitTests/SourceTransmitTests.swift | Adds new regression tests for sequence numbering and universe-discovery packet layout. |
| Sources/sACNKit/Source/sACNSource.swift | Adds internal buildUniverseDiscoveryMessages() seam to support unit testing discovery packet layout. |
| MODERNIZATION.md | Updates Phase 5 status summary to indicate completion and references Phase 5 doc. |
| docs/modernization/phase-5.md | Records PR5 delivered note describing the specific test gaps filled and verification status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.