Skip to content

feat: modernization phase 5 PR5#56

Merged
dsmurfin merged 2 commits into
modernization-planfrom
modernization-phase5-pr5
Jul 19, 2026
Merged

feat: modernization phase 5 PR5#56
dsmurfin merged 2 commits into
modernization-planfrom
modernization-phase5-pr5

Conversation

@dsmurfin

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 19, 2026 14:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR (Modernization Phase 5 PR5) adds regression lock-in for a couple of already-correct on-wire behaviors in the source transmit path, plus accompanying documentation updates for Phase 5 completion.

Changes:

  • Add transmit-builder regression tests covering (1) NULL+PAP sequence consumption in a single frame and (2) universe-discovery reserved-field zeroing and universe-list sorting.
  • Add an internal sACNSource test seam to rebuild and return universe-discovery pages for unit testing.
  • Document Phase 5 completion/status and PR5’s specific coverage additions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Tests/sACNKitTests/SourceTransmitTests.swift Adds new regression tests for sequence numbering and universe-discovery packet layout.
Sources/sACNKit/Source/sACNSource.swift Adds internal buildUniverseDiscoveryMessages() seam to support unit testing discovery packet layout.
MODERNIZATION.md Updates Phase 5 status summary to indicate completion and references Phase 5 doc.
docs/modernization/phase-5.md Records PR5 delivered note describing the specific test gaps filled and verification status.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Tests/sACNKitTests/SourceTransmitTests.swift
Comment thread Tests/sACNKitTests/SourceTransmitTests.swift Outdated
@dsmurfin
dsmurfin merged commit 951393c into modernization-plan Jul 19, 2026
7 checks passed
@dsmurfin
dsmurfin deleted the modernization-phase5-pr5 branch July 19, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants