feat: modernization phase 5 PR4#55
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR continues the Phase 5 modernization work by replacing the legacy transmitCounter-driven keep-alive cadence with independently tracked keep-alive tick counters for levels (NULL) and per-address priority (PAP), and makes both intervals configurable on sACNSource.
Changes:
- Replace
SourceUniverse.transmitCounterwithticksSinceLevels/ticksSincePrioritiesand corresponding reset/advance APIs. - Add configurable keep-alive intervals to
sACNSource(defaults 800 ms NULL / 1000 ms PAP) and drivebuildDataMessages()keep-alives via tick thresholds. - Update/extend unit tests to characterize the new keep-alive behavior and configurability.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/sACNKitTests/SourceUniverseTests.swift | Updates state-machine tests for the new keep-alive tick counters and reset behavior. |
| Tests/sACNKitTests/SourceTransmitTests.swift | Updates keep-alive cadence tests and adds coverage for configurable/clamped keep-alive intervals. |
| Sources/sACNKit/Source/SourceUniverse.swift | Replaces transmitCounter with separate keep-alive tick counters and reset hooks. |
| Sources/sACNKit/Source/sACNSource.swift | Adds keep-alive interval configuration and updates transmit builder logic to use tick-based thresholds. |
| .claude/rules/timing.md | Updates timing documentation to reflect the new default/configurable keep-alive behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.