Skip to content

feat: modernization phase 5 PR4#55

Merged
dsmurfin merged 2 commits into
modernization-planfrom
modernization-phase5-pr4
Jul 19, 2026
Merged

feat: modernization phase 5 PR4#55
dsmurfin merged 2 commits into
modernization-planfrom
modernization-phase5-pr4

Conversation

@dsmurfin

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 19, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the Phase 5 modernization work by replacing the legacy transmitCounter-driven keep-alive cadence with independently tracked keep-alive tick counters for levels (NULL) and per-address priority (PAP), and makes both intervals configurable on sACNSource.

Changes:

  • Replace SourceUniverse.transmitCounter with ticksSinceLevels / ticksSincePriorities and corresponding reset/advance APIs.
  • Add configurable keep-alive intervals to sACNSource (defaults 800 ms NULL / 1000 ms PAP) and drive buildDataMessages() keep-alives via tick thresholds.
  • Update/extend unit tests to characterize the new keep-alive behavior and configurability.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Tests/sACNKitTests/SourceUniverseTests.swift Updates state-machine tests for the new keep-alive tick counters and reset behavior.
Tests/sACNKitTests/SourceTransmitTests.swift Updates keep-alive cadence tests and adds coverage for configurable/clamped keep-alive intervals.
Sources/sACNKit/Source/SourceUniverse.swift Replaces transmitCounter with separate keep-alive tick counters and reset hooks.
Sources/sACNKit/Source/sACNSource.swift Adds keep-alive interval configuration and updates transmit builder logic to use tick-based thresholds.
.claude/rules/timing.md Updates timing documentation to reflect the new default/configurable keep-alive behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Tests/sACNKitTests/SourceTransmitTests.swift Outdated
Comment thread Tests/sACNKitTests/SourceTransmitTests.swift Outdated
Comment thread Tests/sACNKitTests/SourceUniverseTests.swift
Comment thread Sources/sACNKit/Source/sACNSource.swift
@dsmurfin
dsmurfin merged commit 8ceb63e into modernization-plan Jul 19, 2026
7 checks passed
@dsmurfin
dsmurfin deleted the modernization-phase5-pr4 branch July 19, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants