feat: modernization phase 5 PR3#54
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR (Modernization Phase 5 PR3) expands the receiver/merger “merge surface” so consumers can observe priority-related merge state (universe priority and per-address priority activity) in addition to merged levels, while also fixing a newly-reachable universe-priority dedupe bug in sACNMerger.
Changes:
- Surface winning per-slot priorities, whether PAP is active, and the winning universe priority on
sACNReceiverMergedData. - Extend
sACNReceiver.information(for:)to include per-source priority state, and emit/forward a.perAddressPriorityLostevent fromsACNReceiverandsACNReceiverGroup. - Fix
sACNMerger.updateUniversePriorityForSourcededupe logic and add regression tests to pin the behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/sACNKitTests/ReceiverTests.swift | Adds receiver-level tests for surfaced priority fields and PAP-loss event behavior. |
| Tests/sACNKitTests/MergerTests.swift | Adds a regression test to ensure universe-priority decreases trigger a re-merge. |
| Sources/sACNKit/Receiver/sACNReceiverGroup.swift | Adds and forwards a new group event for per-address-priority loss. |
| Sources/sACNKit/Receiver/sACNReceiver.swift | Enables merger output tracking, enriches information(for:), emits PAP-loss events, and includes priority fields in merged payloads. |
| Sources/sACNKit/Receiver/Delegate/sACNReceiverSource.swift | Adds per-source priority state fields to the receiver source info payload. |
| Sources/sACNKit/Receiver/Delegate/sACNReceiverMergedData.swift | Adds merged priority-related fields (per-slot priorities, PAP active flag, universe priority). |
| Sources/sACNKit/Merger/sACNMerger.swift | Exposes internal read of winning per-slot priorities and fixes universe-priority dedupe logic. |
| docs/modernization/phase-5.md | Documents PR3’s delivery note and the uncovered/fixed guard bug. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.