feat: modernization phase 5 PR1#52
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR kicks off Modernization Phase 5 by tightening sACNMerger correctness to match ETC behavior and establishing a dedicated merger test suite to lock in parity regressions going forward.
Changes:
- Add a new characterization/regression suite for
sACNMerger, covering order-independence and PAP/universe-priority edge cases (incl. SACN-403/364 scenarios). - Fix
updatePAPForSourcetrailing-slot clearing and revert-state transitions by deriving the correct “clear extent” when the source was previously reverted to universe priority. - Add Phase 5 planning/traceability documentation describing the staged PR sequence and verification approach.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Tests/sACNKitTests/MergerTests.swift | Adds merger characterization + regression tests for order-independence and PAP/universe-priority corner cases. |
| Sources/sACNKit/Merger/sACNMerger.swift | Adjusts PAP update logic to correctly clear trailing slots after revert-to-universe-priority transitions; exposes internal read access needed by tests/receiver surface. |
| docs/modernization/phase-5.md | Introduces Phase 5 plan and rationale, including ETC parity references and staged PR breakdown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.