feat: modernization phase 4 PR4 A#48
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR continues Modernization Phase 4 by extracting the reserve-before-await lifecycle state machine into a shared helper (LifecycleGate) and migrating component actors to use it, improving consistency across start/stop/updateInterfaces gating.
Changes:
- Added
LifecycleGate(state + stop-supersede flag + stop waiters) and sharedinterfaceDiffhelper. - Refactored
sACNSourceandsACNDiscoveryReceiverto useLifecycleGateinstead of per-actor lifecycle fields. - Added a dedicated
LifecycleGateTestssuite to validate the transition table and diff helper behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/sACNKitTests/LifecycleGateTests.swift | Adds direct transition-table tests for the shared lifecycle gate and interface diff helper. |
| Sources/sACNKit/Source/sACNSource.swift | Replaces the local lifecycle state/flags with LifecycleGate and routes lifecycle decisions through it. |
| Sources/sACNKit/Shared/LifecycleGate.swift | Introduces the shared lifecycle gate and the interfaceDiff helper used by component actors. |
| Sources/sACNKit/Receiver/sACNDiscoveryReceiver.swift | Migrates lifecycle gating/stop waiters to LifecycleGate and reuses interfaceDiff for interface updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.