Skip to content

Avoid substituting buffer bounds that are defined in terms of itself #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsharlet merged 1 commit into from
Jul 14, 2026
Merged

Avoid substituting buffer bounds that are defined in terms of itself #855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions slinky/builder/slide_and_fold_storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ void substitute_bounds(box_expr& bounds, const symbol_map<box_expr>& buffers) {
void substitute_bounds(symbol_map<box_expr>& buffers, var buffer_id, const box_expr& bounds) {
scoped_trace trace("substitute_bounds");
auto dims = make_dims_from_bounds(bounds);
// Don't substitute buffer bounds that are defined in terms of itself, e.g. from define_undef_bounds.
// It seems to work to do this, but it can generate very large expensive expressions to simplify.
for (int d = 0; d < static_cast<int>(dims.size()); ++d) {
if (depends_on(dims[d].bounds.min, buffer_id).buffer_bounds) dims[d].bounds.min = expr();
if (depends_on(dims[d].bounds.max, buffer_id).buffer_bounds) dims[d].bounds.max = expr();
}
for (std::size_t i = 0; i < buffers.size(); ++i) {
if (!buffers[i]) continue;
for (interval_expr& j : *buffers[i]) {
Expand Down
Loading