Skip to content

Fix visualizer output (#374) - #381

Merged
dsharlet merged 5 commits into
mainfrom
srj/js
May 31, 2024
Merged

Fix visualizer output (#374)#381
dsharlet merged 5 commits into
mainfrom
srj/js

Conversation

@steven-johnson

Copy link
Copy Markdown
Collaborator

Fixes #374; also cherry-picks the fix for nested-let-expr and saniziting # from #375

@steven-johnson
steven-johnson requested a review from dsharlet May 31, 2024 21:25
Comment thread runtime/visualize.cc

void visit(const let* l) override {
// TODO: this is wrong and needs attention
// Use a lambda to allow scoped lets within an expression

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clever, I was stumped

Comment thread runtime/visualize.cc
@dsharlet
dsharlet merged commit 97e597e into main May 31, 2024
@steven-johnson
steven-johnson deleted the srj/js branch May 31, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visualizer doesn't understand or_else / and_then

2 participants