Update plugin to work with Hapi v17#3
Open
mringer wants to merge 2 commits into
Open
Conversation
Author
|
@dsdenes bump |
Author
|
Bump @dsdenes |
|
@dsdenes bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I'm sure you're aware Hapi v17 contains breaking changes for plugins and auth as well as the depreciation of callbacks and the introduction of async-await support. This PR includes changes that bring hapi-auth-firebase current with Hapi v17.
Version bump to 1.1.0 (or whatever you think the next version should be)
Update the plugin registration signature to conform to v17 API
plugins
server.register()
Update Auth scheme to work with new v17 API
server.auth.scheme()
h.unauthenticated()
Update tests to conform to v17 plugin.register() API
-- drop callback from register function