fix: scope tailwind dark mode to .class - #20
Merged
Merged
Conversation
Tailwind defaults darkMode to 'media', which makes every dark: variant react to the user's OS preference rather than the in-page theme toggle. Combined with the .dark class set by the toggle, this caused inverted state: light-cream body background but dark-mode utilities still active. Pin darkMode to 'class' so dark: variants only activate when the toggle sets .dark on <html>, matching the rest of the design-token system. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Tailwind's default is `darkMode: 'media'`, which makes every `dark:` utility track the user's OS `prefers-color-scheme` instead of the `.dark` class set by the in-page theme toggle. On a system in OS-dark mode, toggling the site to "light" left the cream body background visible (CSS rule scoped to `.dark body`) but `dark:*` Tailwind utilities stayed on, producing washed-out / inverted text.
Test plan
🤖 Generated with Claude Code