feat(runtime): implement pilot runtime scroll replay#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds PilotRuntime-backed scroll replay and makes
pilot_runtimethe default Runtime Adapter path. The branch also fixes VM service numeric parameter parsing so scroll deltas sent through service extensions execute correctly.What Changed
pilot_runtimeand removed the oldmcp_flutteradapter path.packages/pilot_runtime.Why
Scroll replay needs to cross the real VM service extension boundary, where service extension parameters are delivered as strings. Parsing numeric extension parameters in the app-side runtime keeps Scenario scroll deltas compatible with real debug Runtime Targets.
Verification
dart format .dart analyzedart testflutter testinpackages/pilot_runtimeNotes
A local, unstaged edit remains in
examples/smoke_app/pilot/pilot_runtime_scroll.yamland is not part of this PR.