Conversation
…mcp, remove GPU validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.claude/skills/covering guide, setup, debug, inspect, control, custom-tools, CLI runtime validation, and repo-maintainer workflowsgrill-meskill underexample/.claude/skills/example/lib/main.dartandexample/CLAUDE.mdwith MCP toolkit integration patternspubspec.lock.flutter_mcp/toexample/.gitignorenvimtext fromexample/android/app/build.gradle, disabled GPU validation mode in the macOS debug schemedart formatlint fixes across changed filesRisk Assessment
✅ Low: The change is well-bounded to adding MCP toolkit instrumentation and supporting platform files to the example app, all previous review findings have been addressed, and the new code follows standard documented patterns without material bugs or risks.
Testing
Verified all three fix categories from commit eeaf52e: 1) nvim text cleanup — confirmed no stray nvim in build.gradle 2) flutter_mcp .gitignore — confirmed.flutter_mcp/entry at line 27,git check-ignoreconfirms cache paths are properly ignored, no tracked artifacts remain 3) GPU validation removal — confirmed enableGPUValidationMode removed from Xcode scheme Ran both test suites: root package (1 test) and example app (8 tests) — 9/9 passed. Worktree restored to clean state.Evidence: nvim-check
Evidence: gpu-validation-check
Evidence: gitignore-check
Evidence: tests-root
Evidence: tests-example
Pipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 3 issues found → auto-fixed ✅
example/android/app/build.gradle:46- Stray text 'nvim' inserted on its own line inside thedefaultConfigblock. This is an editor artifact—it is not valid Groovy and will cause the Android Gradle build to fail with a syntax error.example/.flutter_mcp/cache/macos_helper/macos_visual_capture_-585b0c45b152b847:1- 149 KB binary added under.flutter_mcp/cache/. Cache/build artifacts like this binary and its companion.swiftsource file are not intended to be version-controlled—they are regenerated on demand. The.flutter_mcp/directory should be added to.gitignoreor the files should be excluded individually.example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme:62-enableGPUValidationMode = "1"added to the debug Run scheme. This enables Metal GPU validation during every debug launch, which can cause degraded frame rates and false-positive validation warnings in Xcode. Usually only toggled on when actively debugging Metal issues.🔧 Fix: Fix stray nvim text, add .gitignore for flutter_mcp, remove GPU validation
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
grep -rn 'nvim' example/android/app/build.gradle— confirmed no stray nvim textgrep -n 'enableGPUValidationMode' example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme— confirmed GPU validation mode removedgit check-ignore example/.flutter_mcp/cache/macos_helper/...— confirmed .flutter_mcp/ paths are gitignoredcat example/.gitignore— confirmed '.flutter_mcp/' entry at line 27git ls-files -- 'example/.flutter_mcp/'— confirmed no binary artifacts trackedflutter test(root package) — 1 test passedflutter test(example/) — 8/8 tests passed✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.