feat(bridge): add Ask UI launch release#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Risk Assessment
Testing
Ran focused and package-level Dart tests, full Web tests after installing dependencies with a worktree-local npm cache, Flutter runtime tests, release layout validation, and evidence-producing launch/HTTP checks. Reviewer-visible evidence was written to the requested evidence directory; no screenshot was captured because the browser connector reported no available browser, so I captured the served packaged HTML and HTTP artifacts instead.
Evidence: Launch ready JSON contract
Evidence: Packaged workbench HTML served by bridge
Evidence: Packaged workbench root HTTP response
Evidence: Packaged JavaScript asset headers
Evidence: Served workbench/API summary
Root title/assets: <title>Ask UI</title> <script type="module" crossorigin src="/assets/index-CKHto2yr.js"></script> <link rel="stylesheet" crossorigin href="/assets/index-Cf93crWF.css"> API missing response: {"error":"not_found"}Evidence: Unknown API route remains JSON
Evidence: Release layout validation
Bridge release layout is valid.Pipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
cd apps/bridge && dart test test/launch/launch_command_test.dart test/launch/launch_skill_workflow_test.dart test/release/release_layout_validator_test.dart test/server/packaged_web_test.dartcd apps/web && npm test -- src/session/sessionBootstrap.test.ts scripts/copy-dist-to-bridge.test.mjs(initial run failed because local dependencies were not installed)cd apps/web && npm ci(setup attempt failed on user-level npm cache permissions)cd apps/web && rm -rf node_modules .npm-cache && npm ci --cache .npm-cachecd apps/web && npm testcd apps/bridge && dart testcd apps/bridge && dart run tool/validate_release_layout.dartcd packages/ask_ui_runtime && dart test(not applicable; Flutter package requires Flutter SDK)cd packages/ask_ui_runtime && flutter --version && flutter testdart --packages=.dart_tool/package_config.json /var/folders/1b/xbh8qb0d0j11fzyfm0qs0pf40000gn/T/no-mistakes-evidence/01KX83FQRSPFS23VKRA8T74NG5/launch_ready_evidence.dart > /var/folders/1b/xbh8qb0d0j11fzyfm0qs0pf40000gn/T/no-mistakes-evidence/01KX83FQRSPFS23VKRA8T74NG5/launch_ready.jsoncd apps/bridge && dart run bin/ask_ui_bridge.dart --host 127.0.0.1 --port 39877pluscurlchecks for/, packaged JS asset headers, and/api/missing✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.