feat: add Ask UI runtime widget bounds#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
ask_ui_runtimeFlutter package and wires Bridge/Web marker placement to real app-side widget bounds. This lets Selection Comment markers render inside the selected widget area instead of relying on unavailable Flutter Inspector JSON geometry.What Changed
packages/ask_ui_runtimewithregisterAskUiRuntime()to register debug-only Ask UI VM Service extensions.ext.ask_ui.widgetBoundssupport in Bridge and converts Flutter logical bounds to device-screen coordinates withdevicePixelRatio.boundsfrom the runtime extension.Why
Flutter Inspector tree JSON does not expose global widget origins. The runtime extension runs inside the target Flutter app and can use
RenderBox.localToGlobal(Offset.zero)to return reliable bounds for Inspector widget ids.Verification
flutter analyzeinpackages/ask_ui_runtimeflutter testinpackages/ask_ui_runtimedart analyzeinapps/bridgedart testinapps/bridgenpm test -- --runinapps/webnpm run buildinapps/web