Add structured error context details to all commands#315
Merged
Conversation
Add structured JSON error details for operations, paths, URLs, revisions, emails, member IDs, retry-after values, and Dropbox API summaries across file, share-link, restore, and team commands. Collect details through wrapped and joined errors, preserve explicit command-owned details over command context, and avoid false-positive api_summary detection for local path errors. Add golden JSON error output fixtures, schema/docs updates, and subprocess tests that validate JSON error envelopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detailedErrortype andwithJSONErrorDetailsfor wrapping errors with context without overriding the error codeUnwrap() error+Unwrap() []error) to collect details from all layersjsonErrorDetailsForCommandwith auto-attach of--as-membermember_id on Dropbox API errorsapi_summarydetection for local path error messagestestdata/json_contract/error_outputs.json)Test plan
go test ./...passesgolangci-lint runcleanTestJSONErrorDetailsDoesNotTreatLocalPathAsAPISummaryconfirms false-positive fix