Add typed error details schema and deprecated-command error warnings#314
Merged
Conversation
Close error.schema.json details with additionalProperties: false and add typed properties for all known detail keys including bytes_written. Emit deprecated_command warning in JSON error responses for deprecated commands. Add live integration tests validating real command output against the public schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error.schema.jsondetails withadditionalProperties: falseand add typed properties for all known detail keys (argument,arguments,flag,flags,value,path,token_type,login_command,env_var,api_summary,api_endpoint,bytes_written)deprecated_commandwarning in JSON error responses for deprecated commands (consistent with success responses)Test plan
go test ./...passesgolangci-lint runcleanTestDeprecatedShareListLinkJSON*tests pass with updated command setupTestLiveJSONSuccessOutputsValidateAgainstPublicCommandSuccessSchemavalidates version, ls, put, share-link listTestLiveJSONErrorOutputsValidateAgainstPublicErrorSchemavalidates invalid args and deprecated command errorsTestJSONErrorSchemaRejectsUnknownDetailsKeyandTestJSONErrorSchemaRejectsInvalidDetailsTypeconfirm closed schema