Add primitive types and required fields to commands.schema.json#312
Merged
Conversation
…ema.json Enriches the generated command schema with per-field types, required arrays, nested object refs, enum constraints, and date-time formats. Adds a definition schema registry that maps field names to types and validates manifests against manifest.schema.json in tests.
AndreyVMarkelov
force-pushed
the
feat/command-schema-types
branch
from
a90a0c4 to
38a9e3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commands.schema.jsonwith per-field primitive types,requiredarrays, nested object$reflinks, enum constraints, andformat: "date-time"on timestampsinternal/jsonschema/definition_schemas.go— a registry mapping definitions to their type metadata, withdefaultPropertySchemainferring types from field name patternsmanifest.schema.jsonTest plan
go test ./...passesgolangci-lint run ./...cleangofmt -s -l .cleanTestGoldenSuccessOutputsValidateAgainstPublicCommandSuccessSchema— all golden outputs pass typed validationTestPublicCommandSuccessSchemaRejectsInvalidPrimitiveType— catches"false"wherefalse(bool) expectedTestJSONHelpManifestsValidateAgainstPublicManifestSchema— all manifests validate against manifest.schema.json