Fix ls --only-deleted --limit to count filtered entries#307
Merged
Conversation
Previously --limit counted all entries including live files, so --only-deleted --limit N could return fewer than N deleted entries even when more existed. Now pagination continues until enough deleted entries are collected, and resolved DeletedMetadata entries are retained in the filtered output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ls --only-deleted --limit Nto count only deleted entries toward the limit, continuing pagination until enough are foundprepareLsEntriesto retainDeletedMetadataentries that were resolved toFileMetadataviaListRevisionsTest plan
go test ./...passesgolangci-lint run ./...cleangofmt -s -l .cleanTestLsOnlyDeletedLimitCountsFilteredEntries— verifies pagination continues across pages to collect enough deleted entriesTestLsOnlyDeletedLimitTruncatesFilteredPage— verifies pagination stops when a single page satisfies the limit