-
Notifications
You must be signed in to change notification settings - Fork 4
Update actions #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update actions #70
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cc9b6ab
upgrade ci
tamzi ff1d0dc
Test build.gradle optimizations
tamzi d177211
create CI build optimization.md
tamzi 7bb16c4
update ci-workflow-guide.md
tamzi e2e707d
create a quickstart ci doc
tamzi 062bc57
update README.md
tamzi 9f33989
drop to 0.91
tamzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -39,7 +39,20 @@ android { | |||||||||||||||||||||||||||||||||||||
| "proguard-rules.pro" | ||||||||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||
| // Optimize debug builds for CI | ||||||||||||||||||||||||||||||||||||||
| //See if i can add this to build Logic | ||||||||||||||||||||||||||||||||||||||
| debug { | ||||||||||||||||||||||||||||||||||||||
| isMinifyEnabled = false | ||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| // Disable BuildConfig generation for library (not needed, saves build time) | ||||||||||||||||||||||||||||||||||||||
| //See if i can add this to build Logic | ||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+43
to
+50
|
||||||||||||||||||||||||||||||||||||||
| //See if i can add this to build Logic | |
| debug { | |
| isMinifyEnabled = false | |
| } | |
| } | |
| // Disable BuildConfig generation for library (not needed, saves build time) | |
| //See if i can add this to build Logic | |
| // TODO: See if this can be added to build logic. | |
| debug { | |
| isMinifyEnabled = false | |
| } | |
| } | |
| // Disable BuildConfig generation for library (not needed, saves build time) | |
| // TODO: See if this can be added to build logic. |
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same capitalization and punctuation issue as the previous comment. Should be '// TODO: See if this can be added to build logic'.
Suggested change
| //See if i can add this to build Logic | |
| // TODO: See if this can be added to build logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| # CI Build Time Optimization Guide | ||
|
|
||
| ## 🔧 Additional Optimizations to be applied | ||
|
|
||
| ### **1. Skip Unnecessary Tasks** | ||
|
|
||
| Add to `build.gradle.kts`: | ||
|
|
||
| ```kotlin | ||
| tasks.withType<JavaCompile>().configureEach { | ||
| options.isIncremental = true | ||
| } | ||
|
|
||
| // Skip tasks not needed in CI | ||
| tasks.matching { | ||
| it.name.startsWith("generate") && | ||
| it.name.endsWith("BuildConfig") | ||
| }.configureEach { | ||
| enabled = !System.getenv("CI").toBoolean() | ||
| } | ||
| ``` | ||
|
|
||
|
|
||
| ### **3. Optimize Dependencies** | ||
|
|
||
| ```kotlin | ||
| // Use implementation instead of api when possible | ||
| implementation(libs.androidx.core.ktx) // ✅ Better | ||
| api(libs.androidx.core.ktx) // ❌ Slower (forces recompilation) | ||
|
|
||
| // Use compileOnly for large dependencies not needed at runtime | ||
| compileOnly(libs.some.large.library) | ||
| ``` | ||
|
|
||
| ### **4. Enable R8/ProGuard Optimization in CI** | ||
|
|
||
| ```kotlin | ||
| buildTypes { | ||
| debug { | ||
| // Disable minification in debug for faster CI builds | ||
| isMinifyEnabled = false | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ## 🎯 Monitoring Build Performance | ||
|
|
||
|
|
||
| ## 🔍 Troubleshooting | ||
|
|
||
| ### **Build slower after optimization?** | ||
|
|
||
| **Check:** | ||
|
|
||
| 1. Configuration cache warnings: `./gradlew --configuration-cache help` | ||
| 2. Gradle cache hits: Look for "FROM-CACHE" in logs | ||
| 3. Parallel execution: Check if tasks run simultaneously | ||
|
|
||
| **Common issues:** | ||
|
|
||
| - Configuration cache problems with custom plugins | ||
| - Tasks not cacheable (check `@CacheableTask` annotations) | ||
| - Too many workers (reduce if memory issues) | ||
|
|
||
| ### **Configuration cache errors?** | ||
|
|
||
| ```bash | ||
| # Locally test configuration cache | ||
| ./gradlew clean build --configuration-cache | ||
|
|
||
| # If errors, disable temporarily | ||
| ./gradlew build --no-configuration-cache | ||
| ``` | ||
|
|
||
| ### **Out of memory errors?** | ||
|
|
||
| Increase memory in `ci-gradle.properties`: | ||
|
|
||
| ```properties | ||
| org.gradle.jvmargs=-Xmx6144m # Increase from 4GB to 6GB | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ## 📈 Future Improvements | ||
|
|
||
| Consider these for even faster builds: | ||
|
|
||
| - [ ] **Split workflows**: Separate lint/test/build into different workflow files | ||
| - [ ] **Matrix builds**: Build multiple variants in parallel | ||
|
|
||
| --- | ||
|
|
||
| ## 🎓 Learn More | ||
|
|
||
| - [Gradle Performance Guide](https://docs.gradle.org/current/userguide/performance.html) | ||
| - [Configuration Cache](https://docs.gradle.org/current/userguide/configuration_cache.html) | ||
| - [GitHub Actions Optimization](https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows) | ||
| - [Android Build Performance](https://developer.android.com/studio/build/optimize-your-build) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cache-encryption-key parameter is being added but relies on a GitHub secret (GRADLE_ENCRYPTION_KEY) that may not be configured. If this secret is not set up in the repository settings, the workflow will fail or the cache encryption feature will not work as intended. Ensure this secret is properly configured before merging, or consider making this parameter conditional.