Update actions - #68
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI/CD workflow infrastructure for the Chai Design System by updating GitHub Actions versions, optimizing build performance, and adding comprehensive documentation for testing workflows.
Key Changes:
- Updated GitHub Actions dependencies to latest stable versions (v4/v13)
- Enhanced CI pipeline with better caching, artifact management, and conditional instrumented testing
- Added comprehensive CI/CD workflow documentation with testing guidelines
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/main.yml |
Modernized workflow with updated action versions, improved Gradle caching, conditional androidTest execution, and artifact uploads |
docs/ci-workflow-guide.md |
New comprehensive documentation explaining CI/CD workflow structure, test types, and optimization strategies |
README.md |
Added testing roadmap items for compose UI tests and E2E testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| cancel-previous → lint → build → test → androidTest (conditional) | ||
| ``` | ||
|
|
||
| For running all jobs sequentially with depndencies to ensure code quality before proceeding. |
There was a problem hiding this comment.
Corrected spelling of 'depndencies' to 'dependencies'.
Suggested change
| For running all jobs sequentially with depndencies to ensure code quality before proceeding. | |
| For running all jobs sequentially with dependencies to ensure code quality before proceeding. |
|
|
||
| - **Location**: `src/test/` | ||
| - **Run on**: JVM (fast, no emulator) | ||
| - **Purpose**: Test busines logic, utilities, view models |
There was a problem hiding this comment.
Corrected spelling of 'busines' to 'business'.
Suggested change
| - **Purpose**: Test busines logic, utilities, view models | |
| - **Purpose**: Test business logic, utilities, view models |
| } | ||
| ``` | ||
|
|
||
| ### **E2E Tests** (not implemened) |
There was a problem hiding this comment.
Corrected spelling of 'implemened' to 'implemented'.
Suggested change
| ### **E2E Tests** (not implemened) | |
| ### **E2E Tests** (not implemented) |
|
|
||
| - **Purpose**: Test complete user flows across the entire app | ||
| - **Example**: User opens app → navigates through all screens → interacts with all components | ||
| - **Note**: ! Not typicly needed for a component library, bt will add it for a flow:) |
There was a problem hiding this comment.
Corrected spelling of 'typicly' to 'typically' and 'bt' to 'but'.
Suggested change
| - **Note**: ! Not typicly needed for a component library, bt will add it for a flow:) | |
| - **Note**: ! Not typically needed for a component library, but will add it for a flow:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
! Edit this before submitting your PR !(Remove this after editing)
name: Pull request
about: Create a pull request
label: 'triage me'
Fixes Referenced Issue #_.
How can this PR be tested?
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
./gradlew --init-script gradle/init.gradle.kts spotlessApplyto automatically apply formatting)Is this your first Pull Request?
./tools/setup.shFixes #<issue_number_goes_here> 🦕
Screenshot