Remove explicit Kotlin version settings and bump JVM target to 17#67
Merged
Conversation
…ptions Given the small size of this library, unnecessarily restricting the compiler API surface provides no benefit, so both settings are removed.
Align the library's Java bytecode target with Android Gradle Plugin's defaults and modern toolchain requirements. This updates both the Kotlin compiler jvmTarget and the Android compileOptions source/target compatibility to Java 17.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the :launcher library module’s compilation targets to align with the project’s move to Java/Kotlin JVM target 17, while removing explicit Kotlin apiVersion/languageVersion pinning so Kotlin defaults to the Gradle plugin’s configured version.
Changes:
- Bumped Android
compileOptionssourceCompatibility/targetCompatibilityfrom Java 11 to Java 17 for the:launchermodule. - Bumped Kotlin
compilerOptions.jvmTargetfrom JVM 11 to JVM 17 for the:launchermodule. - Removed explicit Kotlin
apiVersionandlanguageVersionsettings (and the related import).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.