Skip to content

topo: skip creating empty meshnet Topology CR for nodes with no links #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msupinodn merged 1 commit into from
May 28, 2026
Merged

topo: skip creating empty meshnet Topology CR for nodes with no links #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions topo/topo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,19 @@ func (m *Manager) topologySpecs(ctx context.Context) ([]*topologyv1.Topology, er
// replace node name with pod name, for peer pod attribute in each link
for nodeName, specs := range nodeSpecs {
for _, spec := range specs {
// Skip Topology CRs with no links: meshnetd's Get RPC
// treats a missing `spec.links` field as an error
// (`could not find 'Link' array in pod's spec`) and the
// CNI plugin then aborts pod sandbox creation with a
// misleading `meshnetd provided no HOST_IP` message.
// For unconnected nodes we simply don't create the CR;
// the meshnet CNI plugin already handles "no Topology
// CR" gracefully and falls through to the next plugin
// in the chain.
if len(spec.Spec.Links) == 0 {
log.V(1).Infof("Skipping empty Topology spec for node %s (no links)", nodeName)
continue
}
for l := range spec.Spec.Links {
link := &spec.Spec.Links[l]
peerSpecs, ok := nodeSpecs[link.PeerPod]
Expand Down
Loading