Skip to content

Do a full iteration graph merge when addition terms have no contractions#94

Merged
drhagen merged 1 commit into
masterfrom
add-inside-multiply
Jul 16, 2026
Merged

Do a full iteration graph merge when addition terms have no contractions#94
drhagen merged 1 commit into
masterfrom
add-inside-multiply

Conversation

@drhagen

@drhagen drhagen commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Stop trying to distribute multiplication over a SumNode when generating iteration graphs.

Fixes #50.

Stop trying to distribute multiplication over a SumNode when generating iteration graphs.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.48%. Comparing base (b9d9c49) to head (b676697).

Files with missing lines Patch % Lines
src/tensora/desugar/_to_iteration_graphs.py 74.28% 2 Missing and 7 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   90.29%   90.48%   +0.18%     
==========================================
  Files          60       60              
  Lines        3133     3162      +29     
  Branches      370      384      +14     
==========================================
+ Hits         2829     2861      +32     
+ Misses        225      219       -6     
- Partials       79       82       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drhagen
drhagen merged commit 1f02e44 into master Jul 16, 2026
22 checks passed
@drhagen
drhagen deleted the add-inside-multiply branch July 16, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addition inside multiplication crashes

2 participants