Skip to content

Skip iteration graphs that put contraction before sparse output#93

Merged
drhagen merged 1 commit into
masterfrom
fix-empty-assemble
Jul 15, 2026
Merged

Skip iteration graphs that put contraction before sparse output#93
drhagen merged 1 commit into
masterfrom
fix-empty-assemble

Conversation

@drhagen

@drhagen drhagen commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Fixes #53.

Ultimately, the issue was that merge_assignment was generating iteration graphs where sparse output layers were being iterated after contraction. This is not legal in the current design, but best_algorithm was picking one of them. Skipping these illegal graphs fixes the issue.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (bba845b) to head (18b6ddc).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   90.24%   90.29%   +0.05%     
==========================================
  Files          60       60              
  Lines        3126     3133       +7     
  Branches      368      370       +2     
==========================================
+ Hits         2821     2829       +8     
+ Misses        226      225       -1     
  Partials       79       79              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drhagen
drhagen merged commit b9d9c49 into master Jul 15, 2026
22 checks passed
@drhagen
drhagen deleted the fix-empty-assemble branch July 15, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A(i,j) = B(I,j) + C(i,k) * D(k,j) all CSR yields empty assemble

2 participants