WIP: Add verbose logging to Zipscript for exceptions#513
Open
tsautier wants to merge 2 commits into
Open
Conversation
Added debug logging for FileNotFoundException to allow diagnosing missing SFVs. Added warn logging with stack trace for IOException reading SFVs. Improved log message formatting for slave availability issues.
Author
tsautier
force-pushed
the
feat/issue-168-zipscript-logging
branch
from
January 14, 2026 23:05
46e2b91 to
d9b09cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When SFV files are missing, unreadable, or when slaves are unavailable during a list operation, ZipscriptList silently catches exceptions or logs generic warnings. This makes diagnosing broken releases or configuration issues extremely difficult.
Solution
Enhanced logging in exception catch blocks to provide clear, actionable feedback without spamming the logs unnecessarily.
Changes Made
FileNotFoundException(MSFV): Now logs atDEBUGlevel ("No SFV file found") instead of being silent.IOException(SFV Read): Now logs atWARNlevel with stack trace, allowing diagnosis of permission/corruption issues.SlaveUnavailableException: Fixed malformed log message (added missing space in "in{}").FileNotFoundException(Dir Deleted): AddedDEBUGlog to indicate directory race conditions.Fixes: #168