Parse and apply SSL protocols from slave.conf#502
Open
tsautier wants to merge 1 commit into
Open
Conversation
Author
tsautier
force-pushed
the
fix/issue-433
branch
from
January 14, 2026 19:39
24ddc08 to
710e935
Compare
tsautier
force-pushed
the
fix/issue-433
branch
from
January 14, 2026 19:55
710e935 to
26d6d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The slave process was ignoring the
protocol.Xsettings inslave.conf. SSL/TLS protocol configuration (e.g., TLSv1.2, TLSv1.3) had no effect because the values were never parsed from the config file.Solution
Add parsing logic for
protocol.Xproperties in the Slave constructor and apply them to the SSL socket.Changes Made
Slave.javaconstructor to iterate and parseprotocol.Xproperties from config_sslProtocolsarrayFixes: #433