Fix ArrayIndexOutOfBoundsException in FileTypeDetector and TypeCheckers - #707
Open
AndreCatarino wants to merge 1 commit into
Open
Fix ArrayIndexOutOfBoundsException in FileTypeDetector and TypeCheckers#707AndreCatarino wants to merge 1 commit into
AndreCatarino wants to merge 1 commit into
Conversation
…IndexOutOfBoundsException by adding defensive checks; Updated QuickTime, RIFF, and MPEG audio type checkers to validate input length; Added unit tests for empty, truncated, and valid file headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes
java.lang.ArrayIndexOutOfBoundsExceptioninFileTypeDetector.detectFileType()and related TypeChecker implementations when processing truncated or incomplete input streams.Root Cause: TypeCheckers (QuickTimeTypeChecker, RiffTypeChecker, MpegAudioTypeChecker) directly access byte array indices without verifying sufficient data is available.
Solution
Changes Made
FileTypeDetector.detectFileType()withoffset >= checker.getByteCount()validationbytes.length < getByteCount()checks in all TypeChecker implementationsFileTypeDetectorTestwith 11 test scenariosTesting
FileType.Unknowninstead of crashingImpact