Compatibility with Godot 4.7 - #84
Open
DarkGrey456 wants to merge 20 commits into
Open
Conversation
RphCos
reviewed
Jul 6, 2026
RphCos
reviewed
Jul 6, 2026
RphCos
reviewed
Jul 6, 2026
RphCos
reviewed
Jul 6, 2026
RphCos
reviewed
Jul 6, 2026
Co-authored-by: rphcos <91429946+RphCos@users.noreply.github.com>
Co-authored-by: rphcos <91429946+RphCos@users.noreply.github.com>
Co-authored-by: rphcos <91429946+RphCos@users.noreply.github.com>
Co-authored-by: rphcos <91429946+RphCos@users.noreply.github.com>
…input_field_resource.gd Co-authored-by: rphcos <91429946+RphCos@users.noreply.github.com>
Author
|
I applied the changes, thanks, I didnt really understand some of that. The addon seemed to be working but I did notice some problems after I made the PR which was uploaded using the webUI, so I will test this with the changes and update my results in the comments. |
|
@DarkGrey456 Some of the issue I flagged only happened when you opened an existing Garderner, and one only appeared once on project start, and none seem to be blocking/breaking Thank you for doing most of the heavy work! |
Author
|
I had to revert/update the Gardener.gd file again to get this working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got the addon to work in Godot 4.7, made the return type explicit from a couple of functions and returned default values where needed,