4.6 Fix - theme_adapter errors caused by the new default theme - #82
Open
Digletto wants to merge 1 commit into
Open
4.6 Fix - theme_adapter errors caused by the new default theme#82Digletto wants to merge 1 commit into
Digletto wants to merge 1 commit into
Conversation
Digletto
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new default theme does not play nice with the theme adapter since there's some style boxes that are now empty instead of flat. Just commented out the sections that cause errors. GUI still looks perfectly fine in the new theme. Should work with the old theme too, but with less adjustments to the GUI from the theme_adapter.
Running on 4.6 relies on the 4.5 fixes in PR #80 !