Fix Windows taskbar pin icon and eliminate compiler warnings - #7
Merged
Conversation
The platform::spawn module on macOS pulls Context via use super::{Context, Result, Terminal}.
Narrowing the parent import to only Result broke the macOS build.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ImageMagick on windows-latest lacks the ICNS decoder module. Python and pip are pre-installed on GitHub runners; Pillow reads ICNS natively on all platforms. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
@draugvar can we merge this in? |
Owner
Sure thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows uses the Win32 icon resource embedded in the .exe for pinned taskbar shortcuts, the runtime window icon Slint sets is not consulted.
Add winresource as a Windows-only build dependency and embed assets/AppIcon.ico in the binary when present. The CI generates it from the existing AppIcon.icns via ImageMagick before cargo build; local builds without the file skip embedding gracefully.
Platform-specific functions in launch.rs (agent_running, shell_safe_dir, quit_gui) and Terminal::spawn in terminal.rs were reachable on all platforms but only ever called from #[cfg(target_os = "macos")] sites, gate them accordingly.
The now-unreachable Linux and Windows platform::spawn modules in terminal.rs are removed; that spawning logic lives in spawn_in_terminal in launch.rs where working_dir support was added. Gate mod test_util to #[cfg(test)] so test infrastructure is not compiled into release binaries. Remove the stray Mutex import from controller.rs.