Adjust release workflow triggers and align close-button glyph docs by draugvar · Pull Request #3 · draugvar/llaunchpad

draugvar · 2026-06-01T17:44:08Z

This PR updates CI/release workflow behavior and documentation consistency following review feedback.

Changes Made

Updated .github/workflows/release.yml to:
- run on pull_request again
- support manual execution via workflow_dispatch (Run workflow)
- keep execution on push to main
Kept the full release pipeline intact when the workflow is run.
Aligned documentation glyphs with the UI close button:
- README.md: ✕ → ×
- CHANGELOG.md: ✕ → × in both relevant entries

These changes ensure CI runs automatically on PR updates (and on main pushes), while still allowing manual runs and keeping docs consistent with the UI.

…UI updates

…and improve version check logic

… and add custom Ollama host support

…ound for HTTP2 framing errors on Windows

Copilot

Pull request overview

This PR prepares the 0.4.0 release by adding custom Ollama host support (including local model discovery), improving UI behavior around model list refresh, tightening shell-safety for spawned commands, and expanding CI/release automation.

Changes:

Add model list replacement helper to preserve selection by model name when the list is rebuilt.
Harden Windows/terminal launch behavior: sanitize OLLAMA_HOST for shell interpolation and adjust cmd.exe set quoting.
Bump version to 0.4.0 and update docs/changelog; expand GitHub Actions workflow to run on PRs with concurrency cancellation.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ui/app.slint	Tweaks banner close icon glyph and typography for better cross-platform rendering.
src/ollama/launch.rs	Tightens URL sanitization and improves Windows `OLLAMA_HOST` setting/quoting for spawned terminals.
src/main.rs	Preserves selected model by name across model list rebuilds via a helper function.
README.md	Documents custom host + local model behavior and updated usage steps.
CHANGELOG.md	Adds `0.4.0` release notes and updates compare links.
Cargo.toml	Bumps crate version to `0.4.0`.
Cargo.lock	Updates locked package version to `0.4.0`.
.github/workflows/release.yml	Runs CI on PRs and adds concurrency; adjusts version gating and job dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  check-version:
    name: Check version
+    needs: test
    runs-on: ubuntu-latest
    outputs:


+2. (Optional) Paste your **Ollama host** URL (default `http://localhost:11434`) and hit
+   **Test** to pull that server's local models into the dropdown.
+3. Choose an **agent** and a **model** from the inline dropdowns.
+4. Hit **Launch**. The status bar confirms what was started. Click the ✕ to dismiss it.


+- **Dismissible status banner** — the success/error banner at the bottom now has a close
+  button (✕) so it can be cleared without waiting for the next event.
+


+- **Windows**: font-based icons (`▾`, `✕`, etc.) render as glyphs instead of boxes —
+  explicit `font-family` fallback list on the affected `Text` elements.


draugvar · 2026-06-01T18:13:15Z

@copilot perche' la CI ha skippato dei passaggi mentre sono in PR? deve fare sempre tutti i passi. e' possibile mettere un "bottone" nella sezione delle PR su github in maniera tale che anche se uno pusha su una PR aperta non parte in automatico. Deve partire solo quando premo il pulsante per farla girare

Copilot · 2026-06-01T18:16:21Z

@copilot perche' la CI ha skippato dei passaggi mentre sono in PR? deve fare sempre tutti i passi. e' possibile mettere un "bottone" nella sezione delle PR su github in maniera tale che anche se uno p...

Fatto in 332633d: ho rimosso il trigger pull_request e aggiunto workflow_dispatch, quindi i push su PR aperte non avviano più la workflow in automatico. La puoi avviare manualmente dal pulsante Run workflow nella tab Actions di GitHub.

draugvar · 2026-06-01T18:21:36Z

@copilot perche' la CI ha skippato dei passaggi mentre sono in PR? deve fare sempre tutti i passi. e' possibile mettere un "bottone" nella sezione delle PR su github in maniera tale che anche se uno p...

Fatto in 332633d: ho rimosso il trigger pull_request e aggiunto workflow_dispatch, quindi i push su PR aperte non avviano più la workflow in automatico. La puoi avviare manualmente dal pulsante Run workflow nella tab Actions di GitHub.

@copilot non e' possibile mettere un bottone nella pagina della pull aperta? dove dice Review required e fa vedere - quando runna - l'avanzamento della CI?

Copilot · 2026-06-01T18:23:00Z

@copilot perche' la CI ha skippato dei passaggi mentre sono in PR? deve fare sempre tutti i passi. e' possibile mettere un "bottone" nella sezione delle PR su github in maniera tale che anche se u...

No, purtroppo non si può aggiungere un bottone personalizzato direttamente nella pagina PR (nella sezione checks/review). Con GitHub Actions il trigger manuale è solo Run workflow nella tab Actions. Se vuoi un trigger dalla PR, l’alternativa più vicina è un comando tipo /run-ci via commento (workflow su issue_comment) che avvia la CI on-demand.

draugvar · 2026-06-01T18:23:57Z

@copilot perche' la CI ha skippato dei passaggi mentre sono in PR? deve fare sempre tutti i passi. e' possibile mettere un "bottone" nella sezione delle PR su github in maniera tale che anche se u...

No, purtroppo non si può aggiungere un bottone personalizzato direttamente nella pagina PR (nella sezione checks/review). Con GitHub Actions il trigger manuale è solo Run workflow nella tab Actions. Se vuoi un trigger dalla PR, l’alternativa più vicina è un comando tipo /run-ci via commento (workflow su issue_comment) che avvia la CI on-demand.

@copilot k allora rimetti la CI su pull-request

Copilot · 2026-06-01T18:27:08Z

@copilot perche' la CI ha skippato dei passaggi mentre sono in PR? deve fare sempre tutti i passi. e' possibile mettere un "bottone" nella sezione delle PR su github in maniera tale che anche ...

Fatto in 5f5c514: ho rimesso il trigger pull_request nella workflow CI, quindi torna a partire automaticamente quando aggiorni una PR aperta.

draugvar added 3 commits June 1, 2026 16:16

Enhance URL safety in shell commands and preserve model selection in …

9bc35fb

…UI updates

Enhance CI workflow: add pull request triggers, concurrency control, …

6dc401e

…and improve version check logic

Bump version to 0.4.0 and update CHANGELOG; enhance UI text rendering…

b8ffe14

… and add custom Ollama host support

draugvar self-assigned this Jun 1, 2026

Update CI configuration: switch to actions/checkout@v5 and add workar…

85a8f65

…ound for HTTP2 framing errors on Windows

draugvar requested a review from Copilot June 1, 2026 17:57

Copilot started reviewing on behalf of draugvar June 1, 2026 17:57 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Copilot started work on behalf of draugvar June 1, 2026 18:03 View session

Gate release jobs on push and align glyph docs

3e6a760

Copilot finished work on behalf of draugvar June 1, 2026 18:10

Copilot started work on behalf of draugvar June 1, 2026 18:13 View session

Run release workflow manually for PR branches

332633d

Copilot finished work on behalf of draugvar June 1, 2026 18:16

Copilot started work on behalf of draugvar June 1, 2026 18:21 View session

Copilot AI changed the title ~~dev~~ Adjust release workflow triggers and align close-button glyph docs Jun 1, 2026

Copilot finished work on behalf of draugvar June 1, 2026 18:23

Copilot started work on behalf of draugvar June 1, 2026 18:24 View session

Re-enable release workflow on pull requests

5f5c514

Copilot finished work on behalf of draugvar June 1, 2026 18:27

draugvar merged commit 9a76b98 into main Jun 1, 2026
10 checks passed

draugvar deleted the dev branch June 1, 2026 18:39

Navigation Menu

Adjust release workflow triggers and align close-button glyph docs - #3

Adjust release workflow triggers and align close-button glyph docs#3
draugvar merged 7 commits into
mainfrom
dev

draugvar commented Jun 1, 2026 •

edited by Copilot AI

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

draugvar commented Jun 1, 2026

Uh oh!

Copilot AI commented Jun 1, 2026

Uh oh!

draugvar commented Jun 1, 2026

Uh oh!

Copilot AI commented Jun 1, 2026

Uh oh!

draugvar commented Jun 1, 2026

Uh oh!

Copilot AI commented Jun 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		- Dismissible status banner — the success/error banner at the bottom now has a close
		button (✕) so it can be cleared without waiting for the next event.

		- Windows: font-based icons (`▾`, `✕`, etc.) render as glyphs instead of boxes —
		explicit `font-family` fallback list on the affected `Text` elements.

Conversation

draugvar commented Jun 1, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

draugvar commented Jun 1, 2026

Uh oh!

Copilot AI commented Jun 1, 2026

Uh oh!

draugvar commented Jun 1, 2026

Uh oh!

Copilot AI commented Jun 1, 2026

Uh oh!

draugvar commented Jun 1, 2026

Uh oh!

Copilot AI commented Jun 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

draugvar commented Jun 1, 2026 •

edited by Copilot AI

Loading