Skip to content

Support Turkish Language and Default Fallback#24

Closed
abdelslam1997 wants to merge 0 commit into
dralshehri:mainfrom
abdelslam1997:main
Closed

Support Turkish Language and Default Fallback#24
abdelslam1997 wants to merge 0 commit into
dralshehri:mainfrom
abdelslam1997:main

Conversation

@abdelslam1997

Copy link
Copy Markdown
Contributor

This PR updates get_locale so that unsupported language codes no longer raise a fatal ValueError, but instead fall back to English. If English ("en") itself is missing, we still raise a clear LookupError. Additionally, it registers a new TurkishLocale class so "tr" is now supported.

@dralshehri

dralshehri commented Jul 23, 2025

Copy link
Copy Markdown
Owner

I appreciate your effort to improve the package!

However, I'd like to request that you split this into two separate pull requests:

  1. Add Turkish language support

  2. Change error handling in get_locale()

For both PRs, please make sure to:

  • Update all relevant tests (the current tests are failing)
  • Update documentation to reflect your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants