refactor(hooks): extract gate detection into invocable-command lib (U5a — PR3) - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
U5a (PR3, gates lane 1 of 3) from
plan_framework_hardening.md: pure-structure extraction of gate detection into an invocable-command library. Zero behavior change — the prerequisite for PR4's blocking enforcement (U5b) and PR5's default task gate (U5c), which branch frommainafter this merges.What changed
.claude/hooks/gate-lib.sh(108 LOC):gate_lib_detect(dir)fills parallelGATE_LABELS/GATE_COMMANDSarrays with runnable per-stack gate commands (TS/JS pnpm/npm-aware, Python uv-aware, Go, Rust) — today's inline block produced display labels only.pre-commit-verification.sh: sources the lib (BASH_SOURCE-relative, CWD-independent) and reconstructs its advisory output from the lib — byte-identical: old-vs-new stdout diffed empty across five fixture contexts (TS/pnpm, TS/npm, Python, Go, Rust); the untouched baseline harness case also passes.pnpm testinscripts/fixtures/failing-projectexecutes and returns the fixture's deliberate nonzero.Provenance
test-hooks.shALL GREEN (no skips);check-invariants.shALL GREEN; CI-equivalent shellcheck clean;bash -nclean.Risk tier
low — behavior-identity is the acceptance criterion and is byte-diff proven; no wiring, docs, or settings changes (deliberately deferred to U5b/U5c).
Test plan
🤖 Generated with Claude Code