Skip to content

Refactor URL query parameter filtering for task ID consistency - #2014

Merged
gaius-qi merged 1 commit into
mainfrom
feature/task-id
Aug 25, 2026
Merged

Refactor URL query parameter filtering for task ID consistency#2014
gaius-qi merged 1 commit into
mainfrom
feature/task-id

Conversation

@gaius-qi

Copy link
Copy Markdown
Member

Description

Extract query parameter filtering into a shared url::filter_query_params utility that sorts remaining params by key and escapes values using Go-compatible url.QueryEscape semantics, ensuring task IDs generated by the client match those produced by the scheduler.

Related Issue

Motivation and Context

Screenshots (if appropriate)

…cheduler logic

Extract query parameter filtering into a shared `url::filter_query_params` utility that sorts remaining params by key and escapes values using Go-compatible `url.QueryEscape` semantics, ensuring task IDs generated by the client match those produced by the scheduler.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.6.0 milestone Aug 25, 2026
@gaius-qi gaius-qi self-assigned this Aug 25, 2026
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 25, 2026
@github-actions
github-actions Bot requested review from bergwolf, chlins and jim3ma August 25, 2026 11:08
@gaius-qi
gaius-qi enabled auto-merge (squash) August 25, 2026 11:09
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.98%. Comparing base (ea54cfc) to head (f2b9aae).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
+ Coverage   53.68%   53.98%   +0.30%     
==========================================
  Files         100      101       +1     
  Lines       26976    27131     +155     
==========================================
+ Hits        14482    14648     +166     
+ Misses      12494    12483      -11     
Files with missing lines Coverage Δ
dragonfly-client-storage/src/content_linux.rs 81.55% <ø> (+0.31%) ⬆️
dragonfly-client-util/src/id_generator/mod.rs 99.52% <100.00%> (+0.92%) ⬆️
dragonfly-client-util/src/url/mod.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi
gaius-qi merged commit 8212ee1 into main Aug 25, 2026
9 checks passed
@gaius-qi
gaius-qi deleted the feature/task-id branch August 25, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants