[pull] main from trunk-io:main - #80
Merged
Merged
Conversation
…1147) ## What Adds an org-wide escape hatch for exercising a specific (e.g. pre-release) **analytics CLI** build in the test-result uploads, without a code change. Set the `ANALYTICS_CLI_PRE_RELEASE_TEST_VERSION` Actions variable to a version and every `analytics-uploader` invocation uses it; set it to `latest` (the default) and the uploader resolves latest itself. Mirrors the change in `trunk-io/trunk2`, `trunk-io/trunk`, and `trunk-io/chimerarepo`. ##⚠️ Input name: `analytics-cli-version` (not `cli-version`) These composite actions **already have a `cli-version` input**, but it means *the trunk CLI under test* (`PLUGINS_TEST_CLI_VERSION`) — unrelated to the analytics uploader. To avoid a collision, the new input is named **`analytics-cli-version`**. ## Why it's threaded through inputs, not `vars` directly The uploader lives inside the `linter_tests`, `tool_tests`, and `action_tests` composite actions, and the `vars` context is **not readable inside composite actions**. So an `analytics-cli-version` input (default `latest`) is added to each, and `${{ vars.ANALYTICS_CLI_PRE_RELEASE_TEST_VERSION }}` is passed at every call site. The uploader step forwards it: `cli-version: ${{ inputs.analytics-cli-version }}`. ## Behavior | `ANALYTICS_CLI_PRE_RELEASE_TEST_VERSION` | `cli-version` used | |---|---| | `latest` (default) | passed to the uploader, which resolves latest itself | | e.g. `0.14.0.pre.beta.2` | that exact version | These steps previously set no `cli-version`, so the `latest` default is behavior-preserving. ## Changes - **`.github/actions/{linter_tests,tool_tests,action_tests}/action.yaml`** — new `analytics-cli-version` input (default `latest`); `Upload prod results` step now sets `cli-version: ${{ inputs.analytics-cli-version }}`. - **Call sites (13)** pass `analytics-cli-version: ${{ vars.ANALYTICS_CLI_PRE_RELEASE_TEST_VERSION }}`: `pr.yaml` (6), `nightly.yaml` (4), `windows_nightly.yaml` (2), `upload_results.reusable.yaml` (1). ## Notes / scope - Wired at **all** call sites uniformly, including the Windows jobs (`windows_nightly.yaml` and the disabled `windows_*` jobs in `pr.yaml`). The uploader step is gated `runner.os != 'Windows'`, so those are harmless no-ops today — but consistent and ready if Windows upload is enabled. - **Out of scope:** `upload_results.reusable.yaml`'s `trunk upload-linter-versions` step is a plugins-specific upload (not the analytics-uploader) and is untouched. The lone `Gemfile` (`linters/brakeman/test_data/`) is linter *test fixture* data, not a CI rspec flow. - I could not run `trunk check` / `trunk fmt` locally (the sandbox proxy blocks `get.trunk.io`); edits match existing indentation and were validated with a YAML parser; the repo's Trunk Check on the PR is the verification. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- _Generated by [Claude Code](https://claude.ai/code/session_019qcw8v8TiTHRGdDSH7J3ia)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )