Skip to content

Display translators alongside authors#408

Merged
cmil merged 2 commits into
mainfrom
391-translators
Jul 11, 2026
Merged

Display translators alongside authors#408
cmil merged 2 commits into
mainfrom
391-translators

Conversation

@cmil

@cmil cmil commented Jul 5, 2026

Copy link
Copy Markdown
Member

Consume the new editors field on plays (dracor-org/dracor-api#368) and surface entries with role "translator" next to authors.

  • Play detail header: render a translator AuthorInfo card with a vertical "Translator" label overlaying the image's left edge; text side is muted. Sticky heading includes the translator name (with a "tr." prefix, italic) in the collapsed state only.
  • Corpus play list: append a muted "trans. …" line under the author names in the Authors column, and fold translator names/refs/aliases into the column's search filter.

Closes #391

@cmil
cmil requested review from lehkost and markschwindt July 5, 2026 19:15
@cmil

cmil commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

@juliajbeine @lehkost @markschwindt This is now deployed on dev.dracor.org, see for example https://dev.dracor.org/gersh/hamlet-prinz-von-daenemark or https://dev.dracor.org/neolat/roterodamus-iphigenia-in-aulide. I would like to merge this soonish unless there are strong objections. Later refinements are of course possible and welcome as always.

@cmil
cmil force-pushed the 391-translators branch from 8cc235d to e584686 Compare July 5, 2026 23:40
@juliajbeine

Copy link
Copy Markdown
Contributor

@cmil, Thank you for the changes. Just one note: I think the abbreviation "transl." is more common than "trans.".

cmil added a commit that referenced this pull request Jul 6, 2026
@cmil

cmil commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@juliajbeine I changed the abbreviation in the list of plays and also in the header of the detail view when scrolled up.

cmil added 2 commits July 6, 2026 19:52
Consume the new `editors` field on plays (dracor-api#368) and surface
entries with role "translator" next to authors.

- Play detail header: render a translator AuthorInfo card with a
  vertical "Translator" label overlaying the image's left edge; text
  side is muted. Sticky heading includes the translator name (with a
  "tr." prefix, italic) in the collapsed state only.
- Corpus play list: append a muted "trans. …" line under the author
  names in the Authors column, and fold translator names/refs/aliases
  into the column's search filter.

Closes #391
@cmil
cmil force-pushed the 391-translators branch from 4cd9c1d to 96f7a29 Compare July 6, 2026 17:52
@juliajbeine

Copy link
Copy Markdown
Contributor

@cmil, great, thanks!

@cmil
cmil merged commit e0ee516 into main Jul 11, 2026
1 check passed
@cmil
cmil deleted the 391-translators branch July 11, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display translators with authors

2 participants