feat(search): per-project configurable search & postcode filter labels#46
Open
rawand-shakir-draad wants to merge 3 commits into
Open
feat(search): per-project configurable search & postcode filter labels#46rawand-shakir-draad wants to merge 3 commits into
rawand-shakir-draad wants to merge 3 commits into
Conversation
Make the label, hint and placeholder of the search and postcode fields configurable per project for both the resource overview and budgeting (stem-begroot) widgets. The placeholder is on by default and can be toggled off; the hint is off by default and opt-in. Also fix postcode space-sensitivity: raw input keeps the space while a sanitized value (spaces stripped) is used for the autofill API lookup, so "1234 AA" works like "1234AA". Default texts live solely in widget-settings.js as the single source of truth; admin forms fall back to empty strings.
- Replace title tooltips on the reset/apply buttons with aria-labels that include the visible button text, so keyboard and screen-reader users get the explanation too (title is mouse-only and unreliably announced) - Extract the postcode whitespace sanitizer into src/location/sanitize-zip.ts and cover it with unit tests (space-tolerant "1234 AA" lookup)
Member
|
Onderdeel van de StukkenBeter puntenlijst, punt 215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the label, hint and placeholder of the search and postcode fields configurable per project for both the resource overview and budgeting (stem-begroot) widgets. The placeholder is on by default and can be toggled off; the hint is off by default and opt-in.
Also fix postcode space-sensitivity: raw input keeps the space while a sanitized value (spaces stripped) is used for the autofill API lookup, so "1234 AA" works like "1234AA".
Default texts live solely in widget-settings.js as the single source of truth; admin forms fall back to empty strings.