This repository was archived by the owner on Jul 15, 2026. It is now read-only.
Add gesture inversion settings to Apple Watch app - #11
Merged
Conversation
- Center timer in the middle row with spacers - Add settings gear button to the right of the timer - Create SettingsView with gesture inversion toggle - Add isInverted property to GestureManager with UserDefaults persistence - In inverted mode: counterclockwise → next, clockwise → previous https://claude.ai/code/session_01NwfWjGZ6sYHeWY1c63VyUr
donny-son
commented
Feb 28, 2026
donny-son
left a comment
Contributor
Author
There was a problem hiding this comment.
Code Review 🥟
깔끔한 PR입니다! 제스처 반전 설정 기능이 잘 구현되었네요.
✅ 잘된 점
- UserDefaults 영속화 적절히 처리됨
(rotationX > 0) != isInverted로직이 간결함- SwiftUI 상태 관리 패턴 잘 따름
- Preview 포함된 점 👍
💡 개선 제안 (선택사항)
1. @AppStorage 사용 고려
// Before
@Published var isInverted: Bool {
didSet { UserDefaults.standard.set(isInverted, forKey: "gestureInverted") }
}
// After - more SwiftUI idiomatic
@AppStorage("gestureInverted") var isInverted = false단, ObservableObject에서 @AppStorage와 @published 조합이 까다로울 수 있어서 현재 방식도 충분히 괜찮습니다.
2. Settings 진입점 피드백
설정 버튼 탭 시 햅틱 피드백 추가하면 UX 향상될 수 있음:
WKInterfaceDevice.current().play(.click)전반적으로 머지해도 될 것 같습니다! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01NwfWjGZ6sYHeWY1c63VyUr