Update and optimize reCAPTCHA script loading - #50
Open
gvanderclay wants to merge 1 commit into
Open
Conversation
gvanderclay
commented
Mar 4, 2024
Comment on lines
+211
to
+219
| const buildScript = () => { | ||
| const script = document.createElement("script"); | ||
| script.src = scriptUrl; | ||
| script.async = true; | ||
| script.defer = true; | ||
| script.onload = renderRecaptcha; | ||
| script.onerror = (event) => onError("Failed to load reCAPTCHA script"); | ||
| document.body.appendChild(script); | ||
| }; |
Author
There was a problem hiding this comment.
Originally I wanted to use the onload query parameter that is mentioned in googles docs. But I could not get it to work.
gvanderclay
commented
Mar 5, 2024
Author
There was a problem hiding this comment.
I reformatted the code to be more aesthetically pleasing IMO. If you disagree, I'll happily revert any formatting changes!
gvanderclay
commented
Mar 5, 2024
| script.async = true; | ||
| script.defer = true; | ||
| script.onload = renderRecaptcha; | ||
| script.onerror = (event) => onError("Failed to load reCAPTCHA script"); |
Author
There was a problem hiding this comment.
This addition allows us to know if the loading the script fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an optimized approach to load reCAPTCHA.
I was having issues where the recaptcha component would hang indefinitely. I dug into the source code to resolve the issue, and noticed there was no way to tell if the loading of the recaptcha script failed. In addition, the reliance on
setIntervalandsetTimeoutraised concerns for potential race conditions at worst, and poorly optimized code at bets.Guided by Google’s documentation on loading reCAPTCHA, this update focuses on event-driven execution and improved race condition handling. This alignment with Google’s documentation enhances the library’s loading efficiency and aims to give better insight into potential errors.
Benchmarks
For these benchmarks I measured the time between calling
openandonVerify.@douglasjunior I look forward to any feedback or critique you have!