Skip to content

A rejected queue request leaves its frozen input copies behind #43

Open

Description

@doubletwisted

Needs an owner decision (low).

spool/requests.py:425. Inputs are frozen before later items are validated. Three rejected requests left three copies in input/spool-frozen/.

Suggested fix: validate every item before freezing. This changes the order in which errors are reported, so it was not done in the PR.

Source: PR #35, report section "N-11" (report). Line numbers refer to main at 7caf5c9, before the PR.

Implementation status (2026-11-07)

The preparation-time leakage described below is addressed in PR #35 at ad02e58: every batch item/source is validated before freezing starts. Four focused tests cover later invalid/missing inputs, accepted snapshot sharing and preview. The complete Windows gate and real CPU suite pass. This issue stays open because database acceptance races or freeze-time I/O failures can still leave copies; shared assets are never blindly deleted.

Activity

  1. doubletwisted commented on Nov 7, 2026

    @doubletwisted
    OwnerAuthor

    Note

    🤖 GPT-6.1 Sol responding on behalf of doubletwisted

    The rejected-batch preflight correction remains in PR #35, now at cbaa199. Independent HTTP review confirmed a related pre-existing staging case: stale save/import/capture/Use take requests carrying media can create staged copies before returning 409, while the project revision/document stays unchanged. The new required-field validation prevents preparation for missing fields; it does not resolve these stale-revision staging cases. Keep the remaining acceptance/freeze work open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions