[watch] Avoid updating running processes state in GetManagedCodeUpdatesAsync#55160
Open
tmat wants to merge 3 commits into
Open
[watch] Avoid updating running processes state in GetManagedCodeUpdatesAsync#55160tmat wants to merge 3 commits into
tmat wants to merge 3 commits into
Conversation
Move capturing of the snapshot from TerminatePeripheralProcessesAsync to the callers.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors dotnet watch Hot Reload process-termination flow to avoid repeatedly capturing snapshots of running processes inside CompilationHandler.TerminatePeripheralProcessesAsync, shifting snapshot selection to the callers.
Changes:
- Move peripheral-process termination out of
CompilationHandler.GetManagedCodeUpdatesAsyncand intoHotReloadDotNetWatcher(and the Aspire control path). - Change
TerminatePeripheralProcessesAsyncto accept concreteRunningProjectinstances rather than project-path selectors. - Expose the current running-project map to callers via
CompilationHandler.CurrentRunningProjects.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Dotnet.Watch/Watch/HotReload/HotReloadDotNetWatcher.cs | Terminates peripheral processes based on the already-computed restart set before handling root-process restart/build steps. |
| src/Dotnet.Watch/Watch/HotReload/CompilationHandler.cs | Refactors termination API to take RunningProject instances, adjusts update-building flow, and exposes current running projects. |
| src/Dotnet.Watch/Watch.Aspire/Server/WatchControlReader.cs | Captures running-project snapshot from CompilationHandler and uses it to terminate/restart requested projects. |
tmat
changed the title
tmat
changed the title
tmat
changed the title
tmat
changed the title
Member
Author
|
@DustinCampbell ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
GetManagedCodeUpdatesAsyncto only populateHotReloadProjectUpdatesBuilderbut not terminate processes or discard updates.Avoid capturing snapshot of running processes multiple times.
Move capturing of the snapshot from
TerminatePeripheralProcessesAsyncto the callers.Move previous update discarding from
GetManagedCodeUpdatesAsynctoApplyManagedCodeAndStaticAssetUpdatesAndRelaunchAsync